Adds functionality allowing size of HardwareSerial's RX buffer to be changed at runtime. #1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n size via HardwareSerial::setRxBufferSize.
coddingtonbear
changed the title
|
Hey :) I will merge this but I am thinking of reworking those buffers to be able to hold way more than a K of data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality analogous to the ESP8266's Arduino core's
HardwareSerial::setRxBufferSize, providing users functionality allowing them to increase the size of the rx buffer as a way of preventing lost characters when using high baud rates. Given that the queue size is only 256 characters by default, it is terribly easy for fast serial connections to exceed the default buffer length.